1443: process hangs when generating diff for large file with 1 line (e.g. minified .js file)

sok***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011 
What version are you running?
1.0.5.1

What steps will reproduce the problem?
1. Commit http://jqueryjs.googlecode.com/files/jquery-1.3.1.min.js to code 
repository as jquery.min.js
2. Replace the file with http://jqueryjs.googlecode.com/files/
jquery-1.3.2.min.js
3. Post the diff to reviewboard
4. View the diff in reviewboard

What is the expected output? What do you see instead?
Expected: useless diff appears on the screen
Actual: nothing on the screen; the apache process CPU consumption goes to 
100% and stays there forever

What operating system are you using? What browser?
Linux, Opera/Firefox

Please provide any additional information below.
apache 2.2.8, mod_python 3.3.1, subversion 1.6.5
chipx86
#1 chipx86 
Probably Pygments. We may want to kill syntax highlighting for minified files (though
that's hard to detect.. maybe key it off by extension).

We won't have support for such a thing until 1.6 at the earliest though, without a
patch. And we'd have to decide how best to even tackle this problem.
  • +Component-DiffViewer
david
#2 david 
I just committed a contributed change to time out when pygments takes a long time.
  • +Fixed