1438: Review files being marked erroneously as deleted.

trevbox*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 6, 2010 
What version are you running?
1.0.5.1 

What's the URL of the page containing the problem?
http://reviewboard.4sight.local:10081/r/222/diff/#index_header
(this is a local address of a review prior to publishing)

What steps will reproduce the problem?
1. From the perforce P4V GUI, create a new pending changelist containing 
files for review.
2. Run the post-review.exe tool against the changelist.
3. When the review appears in Reviewboard for publishing all the edited 
files in the changelist will be marked erroneously as deleted and all the 
newly created files will be missing from the list of files for review 
under the diff section.

What is the expected output? What do you see instead?
I expect to see the edited and newly created files in my changelist to be 
reviewed.

When the review appears in Reviewboard for publishing all the edited files 
in the changelist will be marked erroneously as deleted and all the newly 
created files will be missing.

What operating system are you using? What browser?
Windows XP Professional
Internet Explorer 8

Please provide any additional information below.
chipx86
#1 chipx86 
Do you know what version of Perforce the server is using?

If you use post-review --output-diff, does the diff show deletions too?

It might be worth trying the latest nightlies of post-review.
  • +NeedInfo
#2 vija*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Had similar issue with post-review command line version with perforce.  The
post-review with debug showed that the p4 print -o, would result in the empty tmp
files, that causes sdiff to indicate a deleted file.  repeating the command it worked
fine.  May be a intermittent issue.  Hope this helps.
david
#3 david
  • -NeedInfo
    +Incomplete
#4 trevbox*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
The issue is caused by spaces in my workspace folders which is causing the file 
arguments for the post-review script to be split erroneously