Setup:
- Ubuntu box running review-board
- Windows box submitting a diff
Problem:
When trying to view the diffs for the created review I would get back a
VariableNotFound Exception, with further details in the error debug dump
that patch was failing with hunk errors.
Resolution:
Added in stripping of \r characters to the diff and file in
diffutils.py::patch() before files are written
Better resolution I am too lazy to write:
Detect what system type reviewboard is running under and normalize all
newlines accordingly
