1427: Problems with post-review while uploading diffs
- Incomplete
- Review Board
| thomas******@t-onl****** (Google Code) (Is this you? Claim this profile.) | |
| May 26, 2010 |
What version are you running?
Review Board 1.0.5.1
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1.start post-review --revision-range=84072:84090 -d
2.
3.
What is the expected output? What do you see instead?
expected creating new request (done) and upload diff.
retrieving error message:
>>> Review request created
>>> Uploading diff, size: 1099
>>> HTTP POSTing to http://localhost/api/json/reviewrequests/14/diff/new/:
{'basedir': '/MBC/Dev/siemens/VCLine/branches/PIA'}
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u"time data '(revision 0)' does not match
format '%Y-%m-%d %H:%M:%S'"]}, u'stat': u'fail', u'err': {u'msg': u'One or
more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
What is the wrong formatted date tag within the diff there is no date
specified.
What operating system are you using? What browser?
Kubunto 9.10
FireFox 3.5.5
Apache2
subversion 1.6.5
Please provide any additional information below.
for additional information, the diff looks like:
Index: Src/Tools/StyleCop/UnitTest/TestSources/AutoLoad/MultipleDefinitions.cs
===================================================================
--- Src/Tools/StyleCop/UnitTest/TestSources/AutoLoad/MultipleDefinitions.cs
(revision 0)
+++ Src/Tools/StyleCop/UnitTest/TestSources/AutoLoad/MultipleDefinitions.cs
(revision 84090)
@@ -0,0 +1,35 @@
+using System;
+
+namespace ValidNamespaceName
+{
+
+ public class Class1 // first class-like definition
+ {
+ }
+
+ public enum Enum1 // OK, as we allow additional/multiple enum definitions
+ {
+ VALUE1,
+ VALUE2
+ }
+
+ public class Class2 // UNIT TEST VIOLATION (MV1003)
+ {
+ }
+
+ public struct Struct1 // UNIT TEST VIOLATION (MV1003)
+ {
+ }
+
+ public struct Struct2 // UNIT TEST VIOLATION (MV1003)
+ {
+ }
+
+ public interface ITest1 // UNIT TEST VIOLATION (MV1003)
+ {
+ }
+
+ public interface ITest2 // UNIT TEST VIOLATION (MV1003)
+ {
+ }
+}
Are you sure that this repository is set for Subversion and not Bazaar?
-
+ NeedInfo -
+ Component-SCMTools
We are using subversion and reviewboard is configured for it correctly. Might there be a problem of different local settings between the subversion server and the reviewboard system ? Is there any possible to test the diff import with an externaly created diff file?
The error really looks like it's trying to use the bzr SCMTool. It's possible that it's maybe confused indexing the tool into the database but we've never seen this before.
-
- NeedInfo + Incomplete