1420: When updating a review without any diff change reviewboard records a duplicate diff.
- NotABug
- Review Board
| ryan.ga*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Dec. 22, 2009 |
What version are you running? 1.0.5.1 What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/116998/diff/#index_header What steps will reproduce the problem? 1. Post a review via post-review 2. Post an update via post-review, but don't change the code at all, just something like the testing done section. What is the expected output? What do you see instead? I expect there to be no added diff. For the above URL there should be only one diff, not three. What operating system are you using? What browser? Windows, Firefox 3.5 Please provide any additional information below.
Hi Ryan, post-review intentionally does not do any complex diff comparisons or anything. If you only need to update the change description, you can run post-review with the --change-only flag.
-
+ NotABug -
+ Component-RBTools
Thanks for the heads-up on --change-only. Was this always the case? I'm probably mistaken, but I thought in the past that on the server-side it did an interdiff upon updating the diff before recording a new one.