1403: Diff upload fails if Mercurial (hg) uses the GIT-style diffs

Linu*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 28, 2009
What version are you running?
1.0.5.1

What steps will reproduce the problem?
1. add 

[diff]
git = True

to your ~/.hgrc

2. try to post-review a change

What is the expected output? What do you see instead?

I expect it to post the review. Instead I get this:

kurt@pckurt:~/24h/webshop$ post-review --debug
--server=http://reviews.it.lan --revision-range=1715:1716
>>> svn info
>>> git rev-parse --git-dir
>>> hg root
>>> hg svn info
>>> repository info: Path: http://hg.it.lan/herken/webshop/, Base path: ,
Supports changesets: False
>>> hg diff -r 1715 -r 1716
>>> Looking for 'reviews.it.lan /' cookie in
/home/kurt/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request for None
>>> HTTP POSTing to http://reviews.it.lan/api/json/reviewrequests/new/:
{'repository_path': 'http://hg.it.lan/herken/webshop/'}
>>> Review request created
>>> Uploading diff, size: 2737
>>> HTTP POSTing to
http://reviews.it.lan/api/json/reviewrequests/6/diff/new/: {}
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.

What operating system are you using? What browser?

Ubuntu 9.10 AMD64

Please provide any additional information below.

Mercurial 1.3.1
david
#1 david
Git-style diffs from hg don't have enough information in them to work with review board.
  • +ThirdParty
#2 wol****@gmai***** (Google Code) (Is this you? Claim this profile.)
So, err, what kind of diff should we use?
david
#3 david
Normal mercurial diffs.