1400: RBTools: git-svn integration broken @ commit 5985a3192e52832a5bfb05d7071cb00d93e17c63

tony*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Nov. 23, 2009
What version are you running?
RBTools 0.2 (commit 5985a3192e52832a5bfb05d7071cb00d93e17c63)

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. git svn clone http://any/small/package
2. Edit .git/config to point to a valid reviewboard url
3. git checkout -b test
4. Make an edit
5. git commit 
6. postreview.py -d -n

What is the expected output? What do you see instead?
I expected to see a diff of my changes and all the local commands that were 
issued to generate the diff.  Instead I get the following traceback:

>>> svn info
>>> git rev-parse --git-dir
>>> git svn info
>>> repository info: Path: http://svn.corp.lab126.com/home/svn/repos, Base 
path: /trunk/Users/anthcruz/finger2, Supports changesets: False
>>> git config --get reviewboard.url
Traceback (most recent call last):
  File "/home/acruz/src/opensource/rbtools/rbtools/postreview.py", line 
2678, in <module>
    main()
  File "/home/acruz/src/opensource/rbtools/rbtools/postreview.py", line 
2646, in main
    diff, parent_diff = tool.diff(args)
  File "/home/acruz/src/opensource/rbtools/rbtools/postreview.py", line 
2060, in diff
    self.head_ref]).strip()
AttributeError: 'GitClient' object has no attribute 'head_ref'


What operating system are you using? What browser?
Linux - Ubuntu 9.04.

Please provide any additional information below.
Git version - 1.6.5.1
chipx86
#1 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-High
    +Milestone-RBTools-Release1.0
    +Component-RBTools
chipx86
#2 chipx86
Fixed in r30ad034
  • -Confirmed
    +Fixed
  • +chipx86