140: Cannot view diff

mvan****@vmwar***** (Google Code) (Is this you? Claim this profile.)
June 28, 2007
What's the URL of the page containing the problem?
http://reviewboard.eng.vmware.com/r/487/diff/#index_header

What steps will reproduce the problem?
1. I upload a new diff (it was larger then the original)

What is the expected output? 
The diff

What do you see instead?
list assignment index out of range 
Traceback (most recent call last):
  File "/root/reviewboard/../reviewboard/diffviewer/views.py", line 200, 
in view_diff
    files = get_diff_files(diffset, interdiffset)
  File "/root/reviewboard/../reviewboard/diffviewer/views.py", line 166, 
in get_diff_files
    lambda: get_chunks(filediff))
  File "/root/reviewboard/djblets/util/misc.py", line 43, in cache_memoize
    data = lookup_callable()
  File "/root/reviewboard/../reviewboard/diffviewer/views.py", line 166, 
in 
    lambda: get_chunks(filediff))
  File "/root/reviewboard/../reviewboard/diffviewer/views.py", line 88, in 
get_chunks
    for tag, i1, i2, j1, j2 in differ.get_opcodes():
  File "/root/reviewboard/../reviewboard/diffviewer/myersdiff.py", line 
53, in get_opcodes
    self._gen_diff_data()
  File "/root/reviewboard/../reviewboard/diffviewer/myersdiff.py", line 
143, in _gen_diff_data
    self.minimal_diff)
  File "/root/reviewboard/../reviewboard/diffviewer/myersdiff.py", line 
435, in _lcs
    self._findSMS(a_lower, a_upper, b_lower, b_upper, find_minimal)
  File "/root/reviewboard/../reviewboard/diffviewer/myersdiff.py", line 
253, in _findSMS
    up_vector[up_min - 1] = self.max_lines
IndexError: list assignment index out of range

What operating system are you using? What browser?
Windows XP, Firefox

Please provide any additional information below.
chipx86
#1 chipx86
Fixed. I'll be updating the server tonight. The diff should work after that.
  • +Fixed