1382: Inline review comments are not saved with Firefox 3.6
- Fixed
- Review Board
| robert.********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Oct. 25, 2010 |
What version are you running? Review board 1.0.4 What steps will reproduce the problem? 1. Enter a review comment with Firefox 3.6 2. Submit the review What is the expected output? What do you see instead? The review comments are saved as empty text, but the code positions - file and line number - are saved. What operating system are you using? What browser? Linux/ Firefox 3.6 beta 1 Please provide any additional information below. Existing inline comments are loaded. Comments are said to be saved when reviewing the diff, but appear as empty after publishing.
Just noticed that if I save the comments ( draft review ) with FF 3.6 and then edit the review e.g. with Chromium, the comments are visible. If I edit the review with FF 3.6 they are not visible.
Is this in the big review dialog, or comment flags in the diff viewer? Does shift-reload fix anything?
-
+ NeedInfo
1. It is the big review dialog. The comments are present in the diff viewer, even if I go to the "View reviews" page and then come back to the diff viewer. But once I go to 'Edit review' to publish the review, the inline comments are empty, but the lines they are attached to are listed as expected. 2.Shift-reload does not change anything. This was working properly on Firefox 3.5 FWIW.
This is how the comments section of the review dialog appears. The comment line ( 22 here ) is attached, with the proper contents, but the comment text ( 'Sample comment' ) is instead empty.
-
+ 
Firebug does not catch any errors, and I got the following XMLHttpRequest message:
<div id="review-form-comments" class="review">
<p><input id="id_shipit" class="recommendation" type="checkbox" /> <label
for="id_shipit">Ship It</label></p>
<pre class="body-top editable"></pre>
<div class="comments">
<dl class="diff-comments">
<dt>
<div id="review_draft_comment_container_191">
<table class="sidebyside loading">
<thead>
<tr>
<th class="filename">
<a name="/r/47/diff/5/?file=312#file312line22">/xxxfile</a>
<span class="diffrevision">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr><td><pre> </pre></th></tr>
</tbody>
</table>
</div>
</dt>
<dd>
<pre class="editable comment-editable" id="diff-comment-191">Sample comment.</pre>
<script type="text/javascript">
var editor = $("#diff-comment-191").reviewFormCommentEditor({
path: getDiffAPIPath(5,
312,
null, null,
22),
data: {
action: "set",
num_lines: 1
}
});
$("#edit-diff-comment-191").click(function() {
editor.inlineEditor("startEdit");
});
queueLoadDiffFragment("review_draft_diff_comments", "191",
"312"
);
</script>
</dd>
</dl>
</div>
<pre class="body-bottom editable"></pre>
</div>
Looks like the HTML data contains the proper text, but that it's simply not being transferred to the textarea. My only response I can give right now is that we don't officially support Firefox 3.6 alpha, and this may very well be a browser bug. I can maybe look into this in a few weeks.
-
- NeedInfo + Confirmed -
+ Component-Reviews + Browser
Thanks. I'm still running 3.6 Beta so anytime you need a tester let me know.
This seems to work fine now, so feel free to close ( RB 1.5.0 ).
