1381: diff update doesn't work in web GUI and in post-review utility

ost****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 24, 2010
1389
What version are you running?
1.0.5.1

What's the URL of the page containing the problem?
https://ourdevelserver/rb/r/187/diff/

What steps will reproduce the problem?
1. Create a request with diff (works fine)
2. Try to update diff by "Upload diff" form

What is the expected output? What do you see instead?

The error is displayed with this detail message
{"fields": {"path": ["The diff file is empty"]}, "stat": "fail", "err": 
{"msg": "One or more fields had errors", "code": 105}}

when I try post-review in the terminal, problem is following:

$ post-review -p -r 187 --description "some message"
==> HTTP Authentication Required
Enter username and password for "xxxx" at ourdevelserver
Username: user
Password: 
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.


What operating system are you using? What browser?
Firefox 3.5.1, Opera 10.0.1

Please provide any additional information below.
chipx86
#2 chipx86
I know this is old.. Is it still a problem? If so, we need more information. What
type of repository? What OS is used on the client?
  • +NeedInfo
#3 mur****@murra****** (Google Code) (Is this you? Claim this profile.)
I haven't seen this problem recently.

This was on Ubuntu Karmic.
david
#4 david
Going to assume fixed, then.
  • -NeedInfo
    +Fixed