1365: Typo in documentation

ytim*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Nov. 23, 2009
What's the URL of the page containing the problem?
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/

Describe the problem and any recommendations below.
"CVS and Subversion" paragraph: "To post a review request with all
unchanged files in a tree, simply run:". I think there should be "all
_changed_".

Please provide any additional information below.
Also, in the same paragraph: "CVS and Subversion don’t have a concept of
changesets, so instead the working copy’s uncommitted changes are posted
for review." Technically, this is not correct, because subversion has a
changeset concept since version 1.5, though it may not be supported yet by
post-review tool.
chipx86
#1 chipx86
Yeah, actually what I meant was "uncommitted."

I know that SVN has that concept of changesets, but it's a bit different from what we
support and use internally as changesets. In our case, we're talking about an
in-development change known by the server, such as in Perforce. Review Board doesn't
support SVN's concept of changesets and won't in the same way.
  • +Confirmed
  • +chipx86
chipx86
#2 chipx86
Fixed in r027aa6b.
  • -Confirmed
    +Fixed