1332: New Review request should have default values and automatically ran diff tool
- WontFix
- Review Board
| rahim.******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 26, 2009 |
board.org/ What version are you running? 1.0.3 What's the URL of the page this enhancement relates to, if any? New review page Describe the enhancement and the motivation for it. Every time a user wants create a review the should enter the base path and the Diff file. Before starting the tool they must ran the diff tool. User can set up default base path(s) once and the Review tool can run the diff tool itself. This is the use case/story : The always uses eclipse with subeclipse plugin. So the user always checks out the code in a particular directory User does some changes and wants some review to be done before checking in. Since the base path is always same the review board code run the diff associated with repository automaticatlly, so that the manual step of creating the diff is not needed. Of course , if the user needes to use non default values -- this should be available. What operating system are you using? What browser? Windows XP , IE 7 Please provide any additional information below.
How would RB run diff on your system? This would be a pretty terrible security hole in web browsers :) That said, we really do recommend using the post-review tool instead. With this, there's no need to provide the "base diff path" because post-review will figure it out for you. Also note that there's an eclipse plugin now that'll help post reviews.
-
+ WontFix
Really I am asking for two new features 1) the current user interface for creating new reviews-- user has to submit three information (Repository, Base Path, and diff file).I found that I am using the same values each time (as I am working on the same path ). So the request is to save the information and show a set of default configuartions which the user can during code review creation. I am hoping this would be acceptable request. I _think_ codestriker is doing this with their project concept. 2) As for running diff in the client machine -- generally speaking I agree that running something on the client machine is a possible security hole -- but in this case if the specifies the local of the SVN tool during setup.. I would think that would be OK.
For #1, we *highly* advise using post-review. However, it's not at all an unreasonable request, but is being tracked in another bug. #2 is impossible to do from the web server/browser without some sort of extension. This is exactly why you should be using post-review.