132: Include source context in review e-mails

br***@vmwar***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Aug. 22, 2009 
What steps will reproduce the problem?
1. Cause a comment email to go out
2. Look at the lines where the comments are stated
3. Note that there is no reference for the stated comment

What is the expected output? What do you see instead?

  I would like a the code line the comment refers to put into some sort of
offsetting attribute just above the comment and below the link to that file
and location

What operating system are you using? What browser?
  WinXPsp2 FireFox 2.0.4

Please provide any additional information below.
david
#1 david
  • -Type-Defect
    +Type-Enhancement
    +Component-Reviews
  • +Include source context in review e-mails
david
#2 david
  • -Component-Reviews
    +Component-EMail
david
#3 david
  • +Confirmed
#4 scott.q********@gmai***** (Google Code) (Is this you? Claim this profile.) 
A number of developers here commented on the same thing. I have modified the
review_email.txt template in my local installation to include the first line number
of the change.
  • +
    review_email.diff 
    --- /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc2-py2.4.egg/reviewboard/templates/reviews/review_email.txt	2009-05-11 12:38:54.000000000 -0400
    +++ review_email.txt	2009-05-28 11:52:45.000000000 -0400
    @@ -15,7 +15,7 @@
     {{ comment.text|indent }}
     {% endfor %}{% for comment in review.ordered_comments %}
     
    -{{ comment.filediff.source_file }}
    +{{ comment.filediff.source_file }}:{{comment.first_line}}
     <{{domain_method}}://{{domain}}{{comment.get_review_url}}>
     
     {{ comment.text|indent }}
chipx86
#5 chipx86
  • +Milestone-Release1.1
  • +chipx86
chipx86
#6 chipx86
  • -Confirmed
    +Started
chipx86
#7 chipx86 
Up for review at http://reviews.review-board.org/r/971/
  • +PendingReview
chipx86
#8 chipx86 
Added in r2110.
  • -Started
    +Fixed
  • -PendingReview