1310: post-review fails

dbun****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Sept. 14, 2009 
What version are you running?
reviewboard 1.0.1 on linux amd 64, python 2.6

Please provide any additional information below.
post-review.py fails to submit the diff.

post-review.py 120981 -o -d

>>>> Loaded valid cookie -- no login required
>>>> Attempting to create review request for 120981
>>>> HTTP POSTing to 
> http://reviews.vvisions.com/api/json/reviewrequests/new/:
> {'repository_path': 'VVALBP401:8893', 'changenum': '120981'}
>>>> Review request already exists. Updating it...
>>>> HTTP POSTing to
> http://reviews.vvisions.com/api/json/reviewrequests/4/update_from_change
> num/: {}
>
>>>> Review request created
>>>> Uploading diff, size: 1113
>>>> HTTP POSTing to
> http://reviews.vvisions.com/api/json/reviewrequests/4/diff/new/: {}
> Error uploading diff: One or more fields had errors (105)
>>>> {u'fields': {u'path': [u'[Errno 2] No such file or directory']},
> u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code': 105}}
> Your review request still exists, but the diff is not attached.

Any help would be greatly appreciated. Thanks.
#1 dbun****@gmai***** (Google Code) (Is this you? Claim this profile.) 
This is with perforce btw.
chipx86
#2 chipx86 
The error reporting here is a bit wonky, but I think this is due to not having p4 in
the executable path of the web server. To fetch a file, Review Board needs to execute
'p4 -p <perforce port> print -q <filename>'. I think the "No such file or directory"
is due to us not properly finding p4. That would be the first thing to check. Let me
know, and we'll dig into it further if this is not the case.
  • +NeedInfo
#3 dbun****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Putting p4 in /usr/bin fixed it. Thanks a lot!
chipx86
#4 chipx86 
Glad to hear it :) Hope Review Board works out for you guys!
  • -NeedInfo
    +SetupIssue
  • -Type-Defect
    +Type-Support
  • +chipx86
#5 dbun****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Updating the documentation to include this bit of information i think would be a good
idea. Should i create a new issue about it?
chipx86
#6 chipx86 
A new bug would be good. Yes, we should add this to the docs.

I'm also planning to update Review Board to automatically check when these tools are
missing and warn you. We're a step toward that in this upcoming release with
patch/patch.exe, and will in time provide more checks for Perforce, SVN, etc.