131: Too much cruft at the top of the generated email

br***@vmwar***** (Google Code) (Is this you? Claim this profile.)
June 22, 2007
What steps will reproduce the problem?
1. Create a review request
2. Set review for some recipient.
3. Notice the automatically generated email

What is the expected output?

  I vote for removing the statement altogether.  There's no benefit in
knowing the email is auto-generated.  How would this be different than list
servers?

  If you're going to have a header some place after the meat of the email
would be nice.  Maybe the right place to put this is just after the
response like so:

    > On 2007-06-21 01:39:23, Ben Gertzfield wrote:
    > > Please file a bug to clean up the terrible wording of this message
    here and in bora/mks/hostops/manager/GLManager.c (I know you didn't
    write  it), and to refactor them into the same place.
    > > 
    > >
    > 
    > Lee Ann Rucker wrote:
    >     Aside from the wording (which I've changed in the nib to say  
    "unexpectedly quit" instead of "crash"), any other comments?

    Use 3D instead of 3-D to match the rest of the window.


    - Ben

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://reviewboard.eng.vmware.com/r/423/#review1110
    -----------------------------------------------------------






What do you see instead?

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.eng.vmware.com/r/423/#review1110
-----------------------------------------------------------

> On 2007-06-21 01:39:23, Ben Gertzfield wrote:
> > Please file a bug to clean up the terrible wording of this message here
and in bora/mks/hostops/manager/GLManager.c (I know you didn't write it),
and to refactor them into the same place.
> > 
> >
> 
> Lee Ann Rucker wrote:
>     Aside from the wording (which I've changed in the nib to say
"unexpectedly quit" instead of "crash"), any other comments?

Use 3D instead of 3-D to match the rest of the window.


- Ben




What operating system are you using? What browser?
  WinXPsp2 FireFox 2.0.4

Please provide any additional information below.
#1 PNC****@gmai***** (Google Code) (Is this you? Claim this profile.)
The header is needed for the link to the review, however, I agree there is a bit too
much "stuff" around it.  Perhaps leave it at the top, but change it to:

This is in reply to your review request: 
http://linkfoo/

[email text follows]
david
#2 david
Fixed by Phillip Calvin at http://reviews.review-board.org/r/95/
  • +Fixed