1301: Reviewboard choking on review generated by post-review

bbrans******@vmwar***** (Google Code) (Is this you? Claim this profile.)
Nov. 28, 2009
What version are you running?
? Whatever is currently running at VMware.

What's the URL of the page containing the problem?
https://reviewboard.eng.vmware.com/r/98393/diff/#index_header

What steps will reproduce the problem?
1. File that seems to reproduce the problem is a .sln file
2. post-review
3. view diffs for newly posted review.

What is the expected output? What do you see instead?
Expect to see normal diff screen. Instead I see a screen which says:

The patch to '<filename removed>' didn't apply cleanly. The temporary files 
have been left in '/tmp/reviewboard.vedBCI' for debugging purposes. `patch` 
returned: patching file /tmp/reviewboard.vedBCI/tmpIKYJDQ Hunk #1 FAILED at 
1. 1 out of 1 hunk FAILED -- saving rejects to file 
/tmp/reviewboard.vedBCI/tmpIKYJDQ-new.rej

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/views.py", line 152, in view_diff
    interdiffset, highlighting, True)
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 623, in get_diff_files
    large_data=True)
  File "/usr/lib/python2.5/site-packages/Djblets-0.5rc2.dev_20090610-
py2.5.egg/djblets/util/misc.py", line 143, in cache_memoize
    data = lookup_callable()
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 622, in <lambda>
    enable_syntax_highlighting),
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 345, in get_chunks
    new = get_patched_file(old, filediff)
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 261, in 
get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0rc3.dev_20090610-
py2.5.egg/reviewboard/diffviewer/diffutils.py", line 129, in patch
    (filename, tempdir, patch_output))
Exception: The patch to '<filename removed>' didn't apply cleanly. The 
temporary files have been left in '/tmp/reviewboard.vedBCI' for debugging 
purposes.
`patch` returned: patching file /tmp/reviewboard.vedBCI/tmpIKYJDQ
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file 
/tmp/reviewboard.vedBCI/tmpIKYJDQ-new.rej 

What operating system are you using? What browser?
Chrome 2.0.172.39 on XP SP3

Please provide any additional information below.
I can provide diff if needed, but I don't want to post it publicly.
david
#1 david
I don't know what a .sln file is, but the usual cause for this is either line-ending
or character set mismatch. Can you investigate and make sure that the output of "p5
diff -du" patches against the file in perforce?
  • +NeedInfo
david
#2 david
  • -NeedInfo
    +Incomplete