129: SVN diffs where files are deleted cause errors during patch

PNC****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 6, 2007 
What steps will reproduce the problem?
1. Upload a diff with invalid characteristics (line counts, etc.)
2. Click on "View Diff"

What is the expected output? What do you see instead?
Should show the offending diff AND the error, not just the error.

What operating system are you using? What browser?
Linux, Firefox 2.0.0.4

Please provide any additional information below.
The "offending" diff is attached.
vhost.diff 
Index: contrib/conf/apache-vhost.conf
===================================================================
--- contrib/conf/apache-vhost.conf	(revision 0)
+++ contrib/conf/apache-vhost.conf	(revision 0)
@@ -0,0 +1,30 @@
+<VirtualHost *:8080>
+  ServerName reviewboard.near-time.com
+  DocumentRoot /var/www/reviewboard.near-time.com
+  ErrorDocument 500 /errordocs/500.html
+  
+  # Serve django pages
+  <LocationMatch ^/(.*)$>
+    PythonPath "['/usr/share/'] + ['/usr/share/reviewboard'] + sys.path"
+    SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings
+    SetHandler mod_python
+    PythonHandler django.core.handlers.modpython
+    PythonAutoReload Off
+    PythonDebug Off
+  </LocationMatch>
+  
+  # Serve static media without running it through mod_python (overrides the above)
+  <LocationMatch ^(/(media|css|images|scripts|errordocs))>
+    SetHandler None
+  </LocationMatch>
+  
+  # Alias static media requests to filesystem
+  Alias /css /usr/share/reviewboard/htdocs/css
+  Alias /
#1 PNC****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Actually, invalid diffs are not the core issue here; diffs that delete a file in SVN
are.  I believe that Review Board tries to load the file in the later &quot;right&quot;
revision specified by the diff, and fails, because the file has been deleted.

Could someone please change the steps to reproduce:

What steps will reproduce the problem?
1. Upload an &quot;svn diff -r 454:455&quot; where a file is deleted in 455 but exists in 454.
2. Click on &quot;View Diff&quot;
david
#2 david
  • +Component-DiffViewer
chipx86
#3 chipx86 
This will be fixable when I write the replacement for lsdiff, which gives us some
incorrect data when used against a diff from SVN where a file was deleted.
  • +Component-SCMTools
  • +SVN diffs where files are deleted cause errors during patch
chipx86
#4 chipx86 
According to my tests, this is now fixed in the new diff parser in SVN (r852). Please
give it a try and reopen if it's still causing problems for you.
  • +Fixed