1280: os.uname doesn't exist on windows

jeam****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Aug. 22, 2009
What version are you running?
rbtools nightly 0.2beta2.dev-20090819

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Install rbtools nightly (version above) on windows
2. run post-review -d <changelist number>
3. error will appear

What is the expected output? What do you see instead?
should upload the new review and give the url.
instead, complains about "module' object has no attribute 'uname'

What operating system are you using? What browser?
Windows Vista, browser N/A

Please provide any additional information below.

This has a trivial solution:
issue 646 changed line 1632 of postreview.py to check uname for Solaris.
uname doesn't exist on windows, so line should read instead:

if hasattr(os,'uname') and os.uname()[0] == 'SunOS':

I really need to get installed so that I can just post reviews to the
review board review board :)
#1 jeam****@gmai***** (Google Code) (Is this you? Claim this profile.)
I posted a review to the reviewboard reviewboard (my first! if I did something wrong,
let me know!)
chipx86
#2 chipx86
Committed in r2111.
  • +Fixed
  • -Priority-Medium
    +Priority-High
    +Component-RBTools
    +OpSys-Windows
  • +chipx86
david
#3 david
Christian, did you commit to 1.0.x as well or just trunk?
chipx86
#4 chipx86
Just trunk. This is in rbtools, not Review Board.