126: Some exceptions from SCM tools aren't caught

cuv****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
July 4, 2007
When uploading a new patch, some exceptions aren't caught correctly.

On new review requests, both FileNotFoundException and SCMException will
fall all the way through.  When updating a patch on an existing review
request, FileNotFoundException is caught, but SCMException is still a problem.

The expected behavior is a message like what happens with a completely
invalid patch.

A more minor nit: the upload error message looks different between the
'new' and 'update' pages.  It would be nice if they were consistent.
david
#1 david
  • +Started
  • +david
david
#2 david
Fixed in SVN.
  • -Started
    +Fixed