1198: Add a X-ReviewBoard: domain header to all outgoing e-mails

kirby.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Aug. 22, 2009
1761
It would be really nice for all outgoing e-mails to be tagged with a header
to simplify filtering.  Just like a lot of mailing lists have
X-Mailing-List headers the like.

I think that adding one argument to SpiffyEmailMessage, and add one line
more header with that argument. with the name of the review board instance
(my company has a number of review board instances by project/group
boundaries).  That would allow developers to filter the high volume of
e-mail into separate folders based upon the server it was set to.

A patch is likely to follow, once I can get a test instance setup and
configured to try it out on.
chipx86
#1 chipx86
I'd definitely be fine with that. It might also be nice to have a header for pointing
to the review request in question.
  • +Confirmed
  • +Milestone-Release1.1
    +Component-EMail
chipx86
#2 chipx86
What I'm proposing for this is two new headers: X-ReviewBoard-URL and
X-ReviewRequest-URL.

X-ReviewBoard-URL specifies the URL to the Review Board site.

X-ReviewRequest-URL specifies the URL to the particular review request under discussion.

I imagine this is enough for any filtering (maybe even more than enough). If this
isn't sufficient, though, I'd like to hear what else may be needed/changed.
  • -Confirmed
    +Started
  • +chipx86
chipx86
#3 chipx86
Up for review at http://reviews.review-board.org/r/978/
  • +PendingReview
chipx86
#4 chipx86
Committed in r2108.
  • -Started
    +Fixed
  • -PendingReview