119: Large diffs cause parser error

PNC****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 14, 2007
What steps will reproduce the problem?
1. Create a review request
2. Upload a diff larger than 1MB (not abnormal for branch merges!)

What is the expected output? What do you see instead?
The diff should upload (or at worst, time out due to a FastCGI
configuration error)

Instead, you get an error:
On my installation with mod_python, diffs around 1MB cause the following error:
Exception at /r/116/diff/upload/
Unable to recognize diff format
Request Method: 	POST
Request URL: 	http://stripped.url.com:8080/r/116/diff/upload/
Exception Type: 	Exception
Exception Value: 	Unable to recognize diff format
Exception Location: 	/usr/share/reviewboard/diffviewer/parser.py in
parseFile, line 29

What operating system are you using? What browser?
This is running with mod_python rather than FastCGI, so there is no timeout.

Please provide any additional information below.
Works fine with smaller diffs.  I am sorry I cannot provide a testcase diff.
david
#1 david
  • +Component-DiffViewer
chipx86
#2 chipx86
I'd be curious if anyone's encountered this in a while. Things should be better now I
hope.
chipx86
#3 chipx86
  • +Component-DiffParser
david
#4 david
It's probably safe to assume this is fixed -- there have been a lot of parser changes
since June, and we've had some very large diffs work fine.
david
#5 david
Please reopen if you continue to have problems.
  • +Fixed