1151: post-review [subversion] fails to find correct repository

veste*****@gmai***** (Google Code) (Is this you? Claim this profile.)
July 27, 2009 
What version are you running?
1.0 RC2

What steps will reproduce the problem?
1. I have 2 different subversion repositories. They have the same
repository UUID (same server, different addresses)
2. Both repositories are created in review-board as repository 1 and 2
3. post-review in a folder that belongs to repository 2
4. post-review incorrectly detects the file as belonging to repository 1

What is the expected output? What do you see instead?
post-review detects the correct repost

What operating system are you using? What browser?
post-review on winxp, python 2.5.1 
review-board server on ubuntu 9.04

Please provide any additional information below.
The problem seems to be that only relative paths are looked at, and that it
is not checked if the repos urls are the same. I cannot really figure out
what the _get_relative_path on line 196 i ment to do. Simply removing the
call to this function and replacing it with a check on he repos url. Not
sure if this is the correct way to do this, but it seems to work?

Review posted here: 
http://reviews.review-board.org/r/881
david
#1 david 
The patch posted breaks the very point of the UUID checking, which is to check for
cases where the path is different but the repository is the same.

I'm going to go out on a limb and say that having two repositories which are
different but have the same UUID is a broken setup. The only case where you want the
UUID to be the same is for something like a backup.
  • +WontFix