1145: Description textarea grows 1 line with every character typed while editing it in Chromium for Linux

ads****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Oct. 3, 2009
1170, 1208, 1219, 1262, 1303, 1306 
What version are you running?
Whatever's currently in production at VMware.

What's the URL of the page containing the problem?
Seems to affect any review.

What steps will reproduce the problem?
1. Try to edit the description field of a review in Chromium for Linux.

What is the expected output? What do you see instead?
I expect the text area to only expand when I autowrap to a new line.
Instead it does so every time I type a new character.

What operating system are you using? What browser?
Chromium 3.0.183.0 on Ubuntu 9.04

Please provide any additional information below.
It's possible this is a Chromium bug but it doesn't seem to happen on any 
other webapps.
#2 sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Seeing the same effect with Vista/Chrome 2.0.172.28 and ReviewBoard 1.0RC1.
chipx86
#3 chipx86 
There are a lot of issues with textareas and the version of WebKit that Chrome is
using. It's not just us. We found a forum of people all complaining about similar issues.

For 1.0, we are not officially supporting Chrome at all. We recommend Firefox for the
best experience.

As Chrome matures, we will consider adding it to the support list.
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Browser
#4 sanforda********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Here is the Chromium issue: http://code.google.com/p/chromium/issues/detail?
id=10829&q=textarea row&colspec=ID

And the WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=25938
david
#5 david 
I think it's safe to say this is not our bug :)
  • -Confirmed
    +ThirdParty
chipx86
#6 chipx86
chipx86
#7 chipx86
chipx86
#8 chipx86
chipx86
#9 chipx86
#10 niko****@prokosc******** (Google Code) (Is this you? Claim this profile.) 
It should however be mentioned that Facebook's growing comment area works properly with 
Chrome -- i.e. a solution exists, even if a workaournd needs to be implemented in 
jQuery.
david
#11 david
david
#12 david
#13 cory.mc********@gmai***** (Google Code) (Is this you? Claim this profile.) 
I made this change in djblets, which seems to fix the problem for me.

djblets/media/js/jquery.gravy.js:
-            newHeight = this.element[0].scrollHeight;
+            newHeight = this.element[0].scrollHeight + (this.element.height() - 
this.element[0].clientHeight);

scrollHeight apparently corresponds to clientHeight, which differs from height() in 
chrome but not firefox, for me.  So...I removed the difference, which I presume is 
constant and just due to padding.
chipx86
#14 chipx86 
Hmm, interesting. We'd definitely need to test this at least on Chrome, Safari, IE
and Firefox. Have you then tested in both Chrome and Firefox? And it works in both?
  • -ThirdParty
    +NeedInfo
#15 cory.mc********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes, it fixes the issue in both Chrome[ium] and Firefox in Windows and Linux for me.

I just grabbed Safari for Windows, and I can't reproduce it in an unpatched install.  
Not really sure what's going on there.  Someone who's not me should definitely try it. 
:)
chipx86
#16 chipx86 
Fixed in Djblets on master (r61810c1). Thanks Cory!
  • -NeedInfo
    +Fixed
  • -Priority-Low
    +Priority-Medium
    +Djblets
    +Milestone-Release1.0.x
  • +chipx86
#17 sanforda********@gmai***** (Google Code) (Is this you? Claim this profile.) 
This does not appear to be fixed in 1.0.5.1.  Is there any interest in applying this 
fix for 1.0.x?
#18 paul.pe********@comca****** (Google Code) (Is this you? Claim this profile.) 
Weird, this does *not* happen on my install of ReviewBoard after a recent update to 
a Nightly.
However, this still does happen on http://reviews.reviewboard.org.
Has http://reviews.reviewboard.org been updated?
chipx86
#19 chipx86 
No, not for a little while. I'll be doing an update pretty soon, but I'm waiting to
get a couple more changes in first.