1128: LDAP fails if mail attribute or domain not specified

atro****@gmai***** (Google Code) (Is this you? Claim this profile.)
July 3, 2011
What version are you running?

1.0rc2-3

What's the URL of the page containing the problem?

http://inspect.ingres.com

What steps will reproduce the problem?
1. Set authentication to LDAP
2. Leave E-mail Domain and E-mail LDAP Attribute empty
3. Try to log in with a user in the LDAP directory, it will fail quietly

What is the expected output? What do you see instead?

It just said invalid user, it should log me in from the LDAP
Backtrace:
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979-py2.4.egg/reviewboard/accounts/backends.py",
line 93, in authenticate
    return self.get_or_create_user(username)
  File
"/usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979-py2.4.egg/reviewboard/accounts/backends.py",
line 146, in get_or_create_user
    email=email)
UnboundLocalError: local variable 'email' referenced before assignment


What operating system are you using? What browser?

Server: RHEL5 32 bit, Desktop: ArchLinux 64 bit, Firefox 3

Please provide any additional information below.

I think that should be sufficient :)

Thanks again for providing a great product!
david
#1 david
  • +Component-Accounts
david
#2 david
This is fixed now.
  • +Fixed