1107: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do
- UserError
- Review Board
| ivazq******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| July 26, 2009 |
What version are you running? 1.0b2 What's the URL of the page containing the problem? http://review.transifex.org/r/40/ What steps will reproduce the problem? 1. Make a change 2. Make another change What is the expected output? What do you see instead? The second change will appear 7 hours earlier than the first. What operating system are you using? What browser? Linux, FF 3.0.10 Please provide any additional information below.
From what I can tell, that looks completely correct. The second one is saying it's "2 days, 11 hours ago," while the first is "2 days, 18 hours ago." The second one is more recent. What are you seeing about that that seems wrong?
-
+ NeedInfo
If you look at the descriptions, you'll see that the description in the second change doesn't follow from the description in the first change. If you swap the order of the changes then it makes sense. Also, I'm sure that I did one change shortly after the other, and not -7 hours after.
Oh, okay. So would I be correct in assuming that you posted the review request, then changed the timezone setting (or upgraded, and had a custom timezone configured prior to this), then updated the review request? If so, that would cause this problem, and there's not really anything we can do about it, since timestamps are stored as absolute times (and not relative to a timezone) in the database.
That is unfortunately not what happened. I updated the diff and modified the description, then published the review, then realized that I had missed a change in the description so immediately turned around and made it. Also, when I made the third change it also immediately showed up as being made 7 hours previous.
I don't know, it seems like it's working fine. I really just think you don't have the correct timezone set. You have to make sure to restart the Apache server after setting the timezone or you'll hit odd issues.
