1062: Errors with SVN repositories should be displayed in post-review

veste*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 13, 2012
What steps will reproduce the problem?
1. Make changes to a local svn checkout using an svn client newer than your 
default command line client. I installed a new version of tortoise svn 
without upgrading my command line client.
2. Run post-review. The script fails, complaining it cannot cleartool 
(because it fails to get svn reposity info)
3. I figured out this was due to my svn client being too old. 

"C:\temp\reviewboard-read-only\reviewboard>svn info .
svn: This client is too old to work with working copy '.'.  You need 
to get a newer Subversion client, or to downgrade this working copy. 
See http://subversion.tigris.org/faq.html#working-copy-format-change 
for details." 

What is the expected output? What do you see instead?
post-review should detect a too old svn client

What operating system are you using? What browser?
windows xp, RBTools-0.2beta1-py2.5.egg

See http://groups.google.com/group/reviewboard/browse_thread/thread/a438d3fb071
78147# for the full story.
chipx86
#1 chipx86
  • +Confirmed
  • +Milestone-RBTools-Release1.0
    +Component-RBTools
chipx86
#2 chipx86
The cleartool issue is fixed. The error about the repository being old is perhaps
something we can just pass through to the user. However, we need to figure out how
best to do this, since we ideally don't want to scan the text (which won't work on
non-English locales anyway), but we don't want to show an error when it's just not an
SVN repository.

Downgrading the severity. This may be too much of a corner case with too big an
impact to really do anything about.
  • -Priority-Medium
    +Priority-Low
chipx86
#3 chipx86
  • +Errors with SVN repositories should be displayed in post-review
#4 ento.e******@gmai***** (Google Code) (Is this you? Claim this profile.)
> we ideally don't want to scan the text (which won't work on non-English locales anyway)

We ran into this problem in a Japanese locale environment.
I think you can use the --xml switch which were introduced in version 1.3 [1] to determine the repository URL 
locale-independently. (At least as a fallback since it requires version equal or greater than 1.3)

[1] http://subversion.tigris.org/svn_1.3_releasenotes.html
david
#5 david
I think this is enough of a corner case that it's unlikely we'll ever address it.
  • -Confirmed
    +WontFix