106: need some indicator on "My Dashboard" for which reviews there are comments on and which ones I've commented on.

br***@vmwar***** (Google Code) (Is this you? Claim this profile.)
April 26, 2008 
What's the URL of the page containing the problem?
    http://reviewboard.eng.vmware.com/dashboard/

What steps will reproduce the problem?
1. Choose a review to review.
2. Comment, save, publish
3. No visual indicator shows up on review entry in
   dashboard to show what review you just commented on.

What is the expected output? What do you see instead?
Expected:
        Side icon to indicate that the particular review
        has someone's comments affixed.

Reality:
        No such visual indicator.

What operating system are you using? What browser?
  This is on Windows XP, FireFox 2.0.4

Please provide any additional information below.
david
#1 david
  • -Type-Defect
    +Type-Enhancement
    +Component-Dashboard
chipx86
#2 chipx86 
We now have part of this. You can see if there are new comments. I'm not sure if an
indicator showing that you have commented on it is a good thing to add just because
you can usually keep track of this yourself and it might clutter things up, but if
you have any ideas on how to integrate that cleanly, I'm all ears.
  • +need some indicator on "My Dashboard" for which reviews there are comments on and which ones I've commented on.
chipx86
#3 chipx86
  • -Priority-Medium
    +Priority-Low
#4 d.anthony*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
For what it's worth, we've been using Reviewboard a bit in the tools team where I
work, and I've been having a hard time keeping track of which reviews I've already
commented on sometimes (we have a pretty high queue of reviews). So, I think that
some kind of icon next to the reviews that indicates whether or not you've already
commented on it would be helpful in some cases.
chipx86
#5 chipx86 
This is easier now that we have datagrids.
  • -Priority-Low
    +Priority-High
    +Milestone-Release1.0
#6 bret.m*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I took a crack at an implementation, and have submitted for review:

http://reviews.review-board.org/r/285/

Please take a look and see if you like it.
david
#7 david 
Fixed as r1315.  It'll be a little ugly until Christian makes some new icons (bug 474)
  • +Fixed