1054: reviewboard doesn't escape html
- Duplicate
- Review Board
dark****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
April 16, 2009 | |
What steps will reproduce the problem? 1. edit a review and add some javascript code: <script>alert(document.cookie)</script> 2. publish the review 3. the script is executed and there's no way to remove it from the page. What is the expected output? What do you see instead? all html should be escaped from user input to prevent css attacks. What operating system are you using? What browser? ff3, osx
also, any js added seems to break the functionality of the page. i now can't autocomplete any names on the review i added js to (for vmw folks see review 12439 on reviewboard-qa).
scratch commment #1, the ac problem has nothing to do with this (my group doesn't exist on the new reviewboard server).