1041: Too easy to lose edits

Jason******@gmai***** (Google Code) (Is this you? Claim this profile.)
April 19, 2009
What's the URL of the page containing the problem?
Not available

What steps will reproduce the problem?
1. Initiate a new review, for example using post-review
2. Click in the "Description" field and add a bunch of information.
3. Click "Publish" without clicking "OK" first.

What is the expected output? What do you see instead?
I expect the publish to incorporate my new edits.  Instead, it drops the
new text without warning. It should either disable the publish button while
a field is being edited, incorporate the edits automatically, or prompt the
user to continue ("Field 'blah' not saved. Continue?").


What operating system are you using? What browser?
WinXP64 with Firefox 3 and CentOS4.6 64-bit with Firefox 2.


Please provide any additional information below.
A similar issue occurs when editing other fields (e.g., adding reviewers
("People")) and clicking the "diff" link to switch to the diff view without
hitting the enter key to save the field.  In this case, because there is no
"OK" button for that field, I assumed the edits were "live", especially
after a tab-completion. I later figured out that typing the enter key saved
the field.
chipx86
#1 chipx86
What version are you using? It should be saving all fields before publishing. I
thoroughly tested that code when I wrote it, though I suppose there could be a
regression.
  • +NeedInfo
#2 Jason******@gmai***** (Google Code) (Is this you? Claim this profile.)
The web interface says "review board 1.0beta" at the top, but the person who set it
up says that the code says "0.9".  I'll have him upgrade and see if that fixes it.
chipx86
#3 chipx86
The "beta" should be removed. We had that from day 1. It doesn't actually mean the
beta version.

0.9 definitely didn't prevent you from losing the data like the 1.0 alphas and betas
did, so I'm closing this under the assumption that it is in fact 0.9 that you're
running. Please let me know if this is in fact not true.
  • -NeedInfo
    +Fixed