1028: diffviewer does not show all comments

ksu****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
April 18, 2009
1029 
There is a serious bug in findLineNumRow/addCommentFlags java script 
functions in ReviewBoard Beta 2 which causes some comments not to appear 
on diff viewer page. (Almost 30% of all comments is not visible on my 
reviewboard web site)

addCommentFlags calls findLineNumRow function and passes LINE numbers as 
second and third argument, but findLineNumRow treats second and thirds 
argument as ROW numbers. As the result, findLineNumRow function narrows 
the area of search to much.
#1 ksu****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I've just recreated the issue on review board demo page. You can see it:
http://demo.review-board.org/r/1621/

There are two comments, click the second comment.
chipx86
#2 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-DiffViewer
#3 sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Right, and on http://demo.review-board.org/r/1621/, if you click on "16 lines hidden 
[Expand]" below, the second comment does appear.
chipx86
#4 chipx86 
Fixed in r1906.
  • -Confirmed
    +Fixed
  • +chipx86
chipx86
#5 chipx86