grossag

1011: Interdiff doesn't handle mid-review reverted files correctly

grossag
chipx86
 chipx86
April 21, 2009 
This was repro'd on our internal VMware setup, which uses Perforce.  Not
sure if that matters.

What steps will reproduce the problem?
1. Create a changeset with a few changed files and upload it.
2. Revert one of the files and update the diff.
3. Switch to an interdiff view between the first two revisions.

What is the expected output? What do you see instead?

When I do this, the second revision of the diff shows the reverted file as
being changed back to its original version.  So it has a few "changes"
listed.  This is technically correct, but it would be more helpful to
simply display on the right pane "The file is no longer included in the
current revision of the changeset" or something like that.  That way,
readers won't see it and wonder why I changed the code and instead
understand that I just removed/reverted the file.
#1 veste*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Can second thi
chipx86
#2 chipx86 
Going to push this back to the next release. It's a worthwhile change, but isn't
critical for 1.0 at this point.
  • +Confirmed
  • +Milestone-Release1.5
    +Interdiffs
    +Component-DiffViewer
chipx86
#3 chipx86 
Maybe we can do this for 1.0 afterall..
  • -Milestone-Release1.5
    +Milestone-Release1.0
  • +chipx86
chipx86
#4 chipx86 
So we do show that it's been reverted as part of the revision. The problem was that
we were hitting a cache bug, so we'd show a view of the file sometimes without that
text. It was hit or miss, depending on who viewed the file in what mode in the
diffviewer when.

This should be fixed in r1923. We still show the changes in the diff, and we can take
care of that some other time, but it doesn't hurt so long as that indicator is
showing properly.

Please reopen if you disagree once we've updated the server to beta 3. (Should be soon)
  • -Confirmed
    +Fixed