101: Diff parser cannot handle svnlook-style diffs with (rev #)

PNC****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
June 7, 2007
What steps will reproduce the problem?
1. Upload a diff file that contains header lines that end in (rev 34344)
instead of (revision 34344)

What is the expected output? What do you see instead?
The diff should be handled as though "rev" says "revision".

Instead, the following error occurs:
SCMException at /r/new/
Unable to parse diff revision header '(rev 10958)'
Request Method: 	POST
Request URL: 	http://reviewboard.near-time.com:8080/r/new/
Exception Type: 	SCMException
Exception Value: 	Unable to parse diff revision header '(rev 10958)'
Exception Location: 	/usr/share/reviewboard/scmtools/svn.py in
parse_diff_revision, line 40

What operating system are you using? What browser?
Linux / Firefox

Please provide any additional information below.
A similar problem occurs with svnlook diffs because they include a UTC
timestamp before the (rev ####).  This could be ignored or stripped by the
parser.
--- near-time.net/trunk/README	2007-06-06 15:32:23 UTC (rev 10958)
+++ near-time.net/trunk/README	2007-06-06 15:40:51 UTC (rev 10959)
@@ -14,8 +14,8 @@
 Many Gems and plugins....
 
 == Installation...
+To be determined.
 
-
 == Contact the Developers
 
 Near-Time.net is developed by Blake Watters <blake@near-time.com>,
david
#1 david
  • +Accepted
  • +david
david
#2 david
Fixed in svn (to the best of my knowledge re: the date stuff).  Please let us know if
you have any problems with this.
  • -Accepted
    +Fixed