1007: post-review.py dies on really huge diffs.

jeff****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 1, 2009 
Use post-review.py to submit a really huge diff.  We used the following:
python ./reviewboard/post-review.py /all /of/our /paths --target-
people=person1,person2 -o -r 181
and got this error:
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.

We have a derived .c file that can get really really huge.  We don't review 
this, obviously, but it got stuck into the diff on accident.

Once I removed this derived file, the error went away.  The diff was 22,761 
lines long and 1,399,882 characters long.  The "real" diff was 1,507 lines 
long and 50,639 characters long.
chipx86
#1 chipx86 
What does it say when you run with -d?
  • +NeedInfo
  • +Component-RBTools
    +Scalability
#2 jeff****@gmai***** (Google Code) (Is this you? Claim this profile.) 
httpd-fsdata.c is the huge derived file.


...
>>> svn info lib/src/lib_machineInfo.c
>>> svn info lib/src/lib_machineInfo.c
>>> svn info lib/src/lib_machineInfo.c
>>> svn info uip/webserver/httpd-fsdata.c
>>> svn info uip/webserver/httpd-fsdata.c
>>> svn info uip/webserver/httpd-fsdata.c
>>> Looking for 'reviews.com /' cookie in C:\Documents and Settings\...\Local
Settings\Application Data\.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> HTTP GETting api/json/reviewrequests/215/
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/3/info/
>>> HTTP GETting /api/json/repositories/4/info/
>>> repository info: Path: http://asdf.com/svn/software, Base path:
/trunk/examples/myproject, Supports changesets: False
>>> Uploading diff, size: 2060702
>>> HTTP POSTing to http://asdf.com/api/json/reviewrequests/215/diff/new/:
{'basedir': '/trunk/examples/myproject'}
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u"(2006, 'MySQL server has gone away')"]}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 10
5}}
Your review request still exists, but the diff is not attached.
david
#3 david 
The mysql connection can only handle about a megabyte at a time. I don't think
there's anything we can do about this from the reviewboard side; maybe there's a
mysql option?
  • -NeedInfo
    +ThirdParty