4832: post-review fails to post diff to reviewboard server

kavimalargks

What version are you running?

rbtools-0.4.3

What's the URL of the page containing the problem?

https://kingart.cisco.com/reviews/

What steps will reproduce the problem?

  1. Install python/RBT Tools

C:\RBTools-0.4.3\RBTools-0.4.3>python setup.py install
running install
running bdist_egg
running egg_info
writing RBTools.egg-info\PKG-INFO
writing top-level names to RBTools.egg-info\top_level.txt
writing dependency_links to RBTools.egg-info\dependency_links.txt
writing entry points to RBTools.egg-info\entry_points.txt
reading manifest file 'RBTools.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'README*' under directory 'contrib'
writing manifest file 'RBTools.egg-info\SOURCES.txt'
installing library code to build\bdist.win32\egg
running install_lib
running build_py
creating build\bdist.win32\egg
creating build\bdist.win32\egg\rbtools
creating build\bdist.win32\egg\rbtools\api
copying build\lib\rbtools\api\capabilities.py -> build\bdist.win32\egg\rbtools\api
copying build\lib\rbtools\api\errors.py -> build\bdist.win32\egg\rbtools\api
copying build\lib\rbtools\api\tests.py -> build\bdist.win32\egg\rbtools\api
copying build\lib\rbtools\api__init__.py -> build\bdist.win32\egg\rbtools\api
creating build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\bazaar.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\clearcase.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\cvs.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\git.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\mercurial.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\perforce.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\plastic.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\svn.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients\tests.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\clients__init__.py -> build\bdist.win32\egg\rbtools\clients
copying build\lib\rbtools\postreview.py -> build\bdist.win32\egg\rbtools
copying build\lib\rbtools\tests.py -> build\bdist.win32\egg\rbtools
creating build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils\checks.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils\filesystem.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils\process.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils\testbase.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils\tests.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools\utils__init__.py -> build\bdist.win32\egg\rbtools\utils
copying build\lib\rbtools__init__.py -> build\bdist.win32\egg\rbtools
byte-compiling build\bdist.win32\egg\rbtools\api\capabilities.py to capabilities.pyc
byte-compiling build\bdist.win32\egg\rbtools\api\errors.py to errors.pyc
byte-compiling build\bdist.win32\egg\rbtools\api\tests.py to tests.pyc
byte-compiling build\bdist.win32\egg\rbtools\api__init__.py to init.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\bazaar.py to bazaar.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\clearcase.py to clearcase.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\cvs.py to cvs.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\git.py to git.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\mercurial.py to mercurial.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\perforce.py to perforce.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\plastic.py to plastic.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\svn.py to svn.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients\tests.py to tests.pyc
byte-compiling build\bdist.win32\egg\rbtools\clients__init__.py to init.pyc
byte-compiling build\bdist.win32\egg\rbtools\postreview.py to postreview.pyc
byte-compiling build\bdist.win32\egg\rbtools\tests.py to tests.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils\checks.py to checks.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils\filesystem.py to filesystem.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils\process.py to process.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils\testbase.py to testbase.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils\tests.py to tests.pyc
byte-compiling build\bdist.win32\egg\rbtools\utils__init__.py to init.pyc
byte-compiling build\bdist.win32\egg\rbtools__init__.py to init.pyc
creating build\bdist.win32\egg\EGG-INFO
copying RBTools.egg-info\PKG-INFO -> build\bdist.win32\egg\EGG-INFO
copying RBTools.egg-info\SOURCES.txt -> build\bdist.win32\egg\EGG-INFO
copying RBTools.egg-info\dependency_links.txt -> build\bdist.win32\egg\EGG-INFO
copying RBTools.egg-info\entry_points.txt -> build\bdist.win32\egg\EGG-INFO
copying RBTools.egg-info\top_level.txt -> build\bdist.win32\egg\EGG-INFO
zip_safe flag not set; analyzing archive contents...
creating 'dist\RBTools-0.4.3-py2.7.egg' and adding 'build\bdist.win32\egg' to it
removing 'build\bdist.win32\egg' (and everything under it)
Processing setuptools-0.6c11-py2.7.egg
Copying setuptools-0.6c11-py2.7.egg to c:\python27\lib\site-packages
Adding setuptools 0.6c11 to easy-install.pth file
Installing easy_install-script.py script to C:\Python27\Scripts
Installing easy_install.exe script to C:\Python27\Scripts
Installing easy_install.exe.manifest script to C:\Python27\Scripts
Installing easy_install-2.7-script.py script to C:\Python27\Scripts
Installing easy_install-2.7.exe script to C:\Python27\Scripts
Installing easy_install-2.7.exe.manifest script to C:\Python27\Scripts

Installed c:\python27\lib\site-packages\setuptools-0.6c11-py2.7.egg
Processing dependencies for setuptools==0.6c11
Finished processing dependencies for setuptools==0.6c11
Processing RBTools-0.4.3-py2.7.egg
Copying RBTools-0.4.3-py2.7.egg to c:\python27\lib\site-packages
Adding RBTools 0.4.3 to easy-install.pth file
Installing post-review-script.py script to C:\Python27\Scripts
Installing post-review.exe script to C:\Python27\Scripts
Installing post-review.exe.manifest script to C:\Python27\Scripts

Installed c:\python27\lib\site-packages\rbtools-0.4.3-py2.7.egg
Processing dependencies for RBTools==0.4.3
Finished processing dependencies for RBTools==0.4.3

  1. go to eclipse -> Post review request

Traceback (most recent call last):
File "C:\Python27\Scripts\post-review-script.py", line 8, in <module>
load_entry_point('RBTools==0.4.3', 'console_scripts', 'post-review')()
File "build\bdist.win32\egg\rbtools\postreview.py", line 1280, in main
File "build\bdist.win32\egg\rbtools\postreview.py", line 266, in load_capabilities
File "build\bdist.win32\egg\rbtools\postreview.py", line 698, in api_get
File "build\bdist.win32\egg\rbtools\postreview.py", line 668, in http_get
File "C:\Python27\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "C:\Python27\lib\urllib2.py", line 397, in open
response = meth(req, response)
File "build\bdist.win32\egg\rbtools\postreview.py", line 100, in http_response
File "C:\Python27\lib\urllib2.py", line 429, in error
result = self._call_chain(args)
File "C:\Python27\lib\urllib2.py", line 369, in _call_chain
result = func(
args)
File "C:\Python27\lib\urllib2.py", line 864, in http_error_401
url, req, headers)
File "C:\Python27\lib\urllib2.py", line 842, in http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File "build\bdist.win32\egg\rbtools\postreview.py", line 132, in retry_http_basic_auth
AttributeError: 'NoneType' object has no attribute 'code'

getting this error

What is the expected output? What do you see instead?

review request should be created and posted

What operating system are you using? What browser?

Win10

Please provide any additional information below.

chipx86
#1 chipx86

RBTools 0.4.3 is 6 years old at this point. I'm afraid you'll need to upgrade to a modern version, which should have this fixed.

  • -New
    +Fixed
  • -reviewboard
    +rbtools
  • - post-review fails to post diff to reviewboard server
    +post-review fails to post diff to reviewboard server