4440: Interdiff is incorrect for an updated unpublished draft

sbarinov

What version are you running?

2.0.20

What's the URL of the page containing the problem?

/diff/(n)-(n+1)/

What steps will reproduce the problem?

  1. Publish a new code review request
  2. Add a new line of code and update the review, do not publish the new version - [1.png]
  3. Add another new line of code and update the review again - [2.png]
  4. Check the 1-2 interdiff: there last added line is not shown in the draft (not ok) - [2.png]
  5. Check the orig-2 diff: there are all changes in the draft (ok) - [3.png]
  6. Publish the draft - [4.png]
  7. Check the 1-2 interdiff: there last added line is still not shown in the published review (not ok) - [4.png]
  8. Check the orig-2 diff: there are all changes in the published review (ok) - [5.png]

What is the expected output? What do you see instead?

1-2 interdiff should show me "int b = 2;" and "int c = 3;" during the draft and after I publish it.
Now I can see "int c = 3;" only in orig-2 interdiff.

What operating system are you using? What browser?

Microsoft Windows 8.1 Enterprise
Google Chrome Version 51.0.2704.103 m

Please provide any additional information below.

I use P4 with RBTools 0.5.2 in order to post (post-review changelistId) and update (post-review -r reviewId changelistId) review requests.

#1 sbarinov

Could anyone please let me know if this issue is known or already fixed in newer versions?
May be I'm doing something wrong during the post review process that leads to this issue?

david
#2 david

This is fixed in the 2.5 series.

  • -New
    +Fixed