4240: Numerical per file & overall diff stats rather than visual indicators

darrenmoffat

What version are you running?

2.5.2

What's the URL of the page this enhancement relates to, if any?

diff view

Describe the enhancement and the motivation for it.

We are evaluating ReviewBoard as an alternate to our how grown "webrev" tool. In "webrev" we have overall and per file stats on the number of lines added/removed/changed/unchanged.

What operating system are you using? What browser?

OS: Solaris.

Browsers: Firefox, Chrome

Please provide any additional information below.

Example for the over all stats we have:

Summary of changes: 2548 lines changed: 1919 ins; 157 del; 472 mod; 48987 unchg

Then per file entries like: 39 lines changed: 24 ins; 3 del; 12 mod; 34 unchg

The expectation is that the per file stats would be listed either as an alternative to the coloured dots or in addition to them.

You can see an example of webrev output with the stats here:

https://ips.java.net/webrev/barts/21868331/

#1 darrenmoffat

Looks like some of this might be covered by: https://reviews.reviewboard.org/r/7880/

#2 darrenmoffat

Upgraded to 2.5.3.

For an existing review tool tips are showing up with the '%d' rather than the actual values.

#3 darrenmoffat

Same thing is happening for new reviews

gmyers
#4 gmyers

A fix for the '%d' bug you noted has been posted for review at https://reviews.reviewboard.org/r/8030/

david
#5 david
  • -New
    +Fixed