3884: New Review Request page should take a base commit ID

chipx86
What version are you running?
2.0.x

What's the URL of the page containing the problem?
/r/new/

What steps will reproduce the problem?
1. Post a locally-generated diff against a Git repository on Bitbucket
2. See a file not found error.

What is the expected output? What do you see instead?
We should either propagate the error message stating that a base commit ID is needed and to use RBTools, or we really should offer a field to fill in (much like we do with base paths).

As it is, it's pretty confusing for users, who just think their diff is bad.
david
#1 david

This is now prompted for if necessary.

  • -Confirmed
    +Fixed